xades4j sugestions for changes -

xades4j sugestions for changes -

i have list of suggestion xades4j. these minor changes in xades4j usability.

class defaulttimestamptokenprovider

it should possible override method gethttpconnection(). opinion, today in many enterprises systems behind proxy. so, if gethttpconnection can have custom implementation, different way set connection, or may else i'm not thinking @ moment, more generic.

class objectidentifier

i implemented signaturepolicydocumentprovider. in used hashmap store policies. , in order have method getsignaturepolicydocumentstream working correctly, had add together methods hashcode() , equals() objectidentifier (eclipse generated code).

interface keystorekeyingdataprovider.signingcertselector

i imagining scenario have keystore several private keys different alias , utilize selectcertificate select right 1 based on alias. rhe method selectcertificate have input list of x509certificates not possible, need have kind of hashmap. because beingness list, easy position, other types of logic become hard.

thoughts?

in general, agree suggestions:

that approach used on authenticatedtimestamptokenprovider. think gethttpconnection() method isn't protected mistake... however, have more generic planned: separate deed of obtaining tsresponse remaining logic (something strategy pattern). way we'd have ts provider , a, lets say, "httptsresponseresolver" (or others).

noted. agree can useful. i'll see if identifier string sufficient hash code or if identifier type must included.

noted. arguments should list of pairs.

thanks feedback!

xades4j